Add information linear and non-linear solver outputs #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hepap
force-pushed
the
add_information_linear_solver_output
branch
from
60aabc4 to
9e9b060
Compare
AmishgaAlphonius
approved these changes
Mar 22, 2024
source/solvers/navier_stokes_base.cc
Outdated
Comment on lines
2511
to
2520
| for (auto j = index_set_velocity[d].begin(); | ||
| j != index_set_velocity[d].end(); | ||
| j++) | ||
| { | ||
| double dof_newton_update = newton_update[*j]; | ||
|
|
||
| local_sum += dof_newton_update * dof_newton_update; | ||
|
|
||
| if (dof_newton_update > local_max) | ||
| { | ||
| local_max = dof_newton_update; | ||
| } | ||
| } |
There was a problem hiding this comment.
These loops on index_sets could be inlined if you wish :)
…and pressure components
Co-authored-by: Pierre Laurentin <[email protected]> Co-authored-by: Amishga Alphonius <[email protected]>
hepap
force-pushed
the
add_information_linear_solver_output
branch
from
1051d53 to
f533a1f
Compare
hepap
added
Reviewed and ready to merge
and removed
Reviewed and waiting for changes
labels
|
I think it is ready to merge if the tests pass! The output was added for CH as well :) |
|
@hepap some tests are breaking, can you double check them? |
blaisb
approved these changes
Apr 5, 2024
|
Should be alright now! |
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
) Description of the problem The console output of the non-linear solver in the NS solver was showing the the norms of the newton update without distinction between the velocity and pressure contributions. The final residual norm of the linear solver was not outputted, only the tolerance. Description of the solution Add the distinction between the velocity and pressure contributions in the non-linear solver output. Add the final value of the linear residual when verbosity is at verbose. If it is at extra verbose, the solver output the residual for each iteration (already implemented but not documented). How Has This Been Tested? A unit test was added. vector_problem.cc Co-authored-by: Pierre Laurentin <[email protected]> Co-authored-by: Amishga Alphonius <[email protected]> Former-commit-id: 4632e53
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem The console output of the non-linear solver in the NS solver was showing the the norms of the newton update without distinction between the velocity and pressure contributions. The final residual norm of the linear solver was not outputted, only the tolerance. Description of the solution Add the distinction between the velocity and pressure contributions in the non-linear solver output. Add the final value of the linear residual when verbosity is at verbose. If it is at extra verbose, the solver output the residual for each iteration (already implemented but not documented). How Has This Been Tested? A unit test was added. vector_problem.cc Co-authored-by: Pierre Laurentin <[email protected]> Co-authored-by: Amishga Alphonius <[email protected]> Former-commit-id: 4632e53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
How Has This Been Tested?
A unit test was added.
Documentation
Add a comment for the extra verbose verbosity of the linear solver.